argo-ui icon indicating copy to clipboard operation
argo-ui copied to clipboard
verified publisher icon argoproj

fix(side-navbar): keyboard a11y

Open gaurav5430 opened this issue 3 years ago • 7 comments

replace div with button to allow activation using space and enter.

This fixes one of the issues mentioned in https://github.com/argoproj/argo-ui/issues/221

gaurav5430 avatar May 20 '22 18:05 gaurav5430

Stale pull request message

github-actions[bot] avatar Jul 20 '22 11:07 github-actions[bot]

Looks like DCO is missing a space (between name and the <)

agilgur5 avatar Aug 16 '23 18:08 agilgur5

Looks like DCO is missing a space (between name and the <)

Thanks for reopening this, I might find time to fix the DCO issue and rebase this

gaurav5430 avatar Aug 16 '23 18:08 gaurav5430

Stale pull request message

github-actions[bot] avatar Oct 16 '23 11:10 github-actions[bot]

Stale pull request message

github-actions[bot] avatar Dec 16 '23 11:12 github-actions[bot]

Stale pull request message

github-actions[bot] avatar Feb 15 '24 11:02 github-actions[bot]

I think that this would also make the buttons clickable with vimium!

michaelfresco avatar Mar 23 '24 02:03 michaelfresco