argo-rollouts icon indicating copy to clipboard operation
argo-rollouts copied to clipboard

feat: adds nodeselector to deployment

Open rparsonsbb opened this issue 4 years ago • 5 comments

Adds note about not using install.yaml from master adds blackbook to official rollout user adds OS nodeselector to all deployments

rparsonsbb avatar Apr 03 '20 18:04 rparsonsbb

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 03 '20 18:04 CLAassistant

Codecov Report

Merging #462 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #462   +/-   ##
=======================================
  Coverage   85.17%   85.17%           
=======================================
  Files          80       80           
  Lines        7539     7539           
=======================================
  Hits         6421     6421           
  Misses        804      804           
  Partials      314      314

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ebfd2f5...c976351. Read the comment docs.

codecov[bot] avatar Apr 03 '20 18:04 codecov[bot]

Hey @rparsonsbb, I wanted to circle back on this PR. Could we add a comment to the installation guide that this version runs on Linux and you will need to add a node selector like the following if you have a cluster with multiple OSs?

spec:
  template:
    spec:
      nodeSelector:
        beta.kubernetes.io/os: linux

dthomson25 avatar May 28 '20 18:05 dthomson25

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarcloud[bot] avatar Dec 18 '20 22:12 sonarcloud[bot]

Thoughts on closing this one in favor of using kustomize instead?

pragmaticivan avatar Jun 02 '22 15:06 pragmaticivan

This PR is stale because it has been open 90 days with no activity.

github-actions[bot] avatar Dec 07 '22 02:12 github-actions[bot]