argo-rollouts
argo-rollouts copied to clipboard
feat: adds nodeselector to deployment
Adds note about not using install.yaml from master adds blackbook to official rollout user adds OS nodeselector to all deployments
Codecov Report
Merging #462 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #462 +/- ##
=======================================
Coverage 85.17% 85.17%
=======================================
Files 80 80
Lines 7539 7539
=======================================
Hits 6421 6421
Misses 804 804
Partials 314 314
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ebfd2f5...c976351. Read the comment docs.
Hey @rparsonsbb, I wanted to circle back on this PR. Could we add a comment to the installation guide that this version runs on Linux and you will need to add a node selector like the following if you have a cluster with multiple OSs?
spec:
template:
spec:
nodeSelector:
beta.kubernetes.io/os: linux
Thoughts on closing this one in favor of using kustomize instead?
This PR is stale because it has been open 90 days with no activity.