argo-rollouts icon indicating copy to clipboard operation
argo-rollouts copied to clipboard

Add option for set suffix in canary pod name

Open oliveiraxavier opened this issue 1 year ago • 1 comments

Summary

During rollout, all pods have the same name and prefix. It visually it is not so quick to differentiate pods that are canary and stable.

What change needs making?

It would be interesting to have a way for canary pods to have a suffix (eg rollout-deploy-canary-xxxxx-yyyy) while stable pods have rollout-deploy-xxxxx-yyyy. After everything was promoted, all pods would have rollouts -deploy-xxxxx-yyyy

Use Cases

When would you use this? In same cases, the k8s, want to see pods for rollouts in kubectl get pods or k9s


oliveiraxavier avatar Oct 14 '24 03:10 oliveiraxavier

Can't you use Ephemeral Metadata and labels for this? EG: kubectl get pods -n $NAMESPACE -l labelKey=labelValue

zimmertr avatar Oct 16 '24 19:10 zimmertr

In my scenario, this doesn't suit me. For example, if you open a service with the same name in k9s, all pods will have the same name, visually (without filter label), it is not quick to know which is canary or which is stable

oliveiraxavier avatar Oct 18 '24 04:10 oliveiraxavier

Pods cannot be renamed once created in kubernetes as the api would not allow it, so this would run into issues when it comes time to promote canary pods to stable pods depending on the rollout type chosen. But going based on the canary terminology I am assuming this is a canary release. Because whatever name is "canary" during the release, will suddenly become stable after the rollout finishes and will keep that replica set + pod name convention.

You might could look at some sort of generic naming rotation, but depending on replica set history you have you might run into a situation where two replica sets have the same value

mmcken3 avatar Nov 09 '24 01:11 mmcken3

Thanks for answers.

oliveiraxavier avatar Nov 09 '24 02:11 oliveiraxavier