argo-rollouts
argo-rollouts copied to clipboard
feat(experiments): add ability to set service port mappings
Adds enhancement #3428
Checklist:
- [x] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
- [x] The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g.
"fix(controller): Updates such and such. Fixes #1234"
. - [x] I've signed my commits with DCO
- [x] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
- [x] My builds are green. Try syncing with master if they are not.
- [ ] My organization is added to USERS.md.
Go Published Test Results
2 160 tests 2 160 :white_check_mark: 2m 53s :stopwatch: 119 suites 0 :zzz: 1 files 0 :x:
Results for commit 4a99969b.
:recycle: This comment has been updated with latest results.
E2E Tests Published Test Results
4 files 4 suites 3h 29m 2s :stopwatch: 111 tests 98 :white_check_mark: 6 :zzz: 7 :x: 458 runs 420 :white_check_mark: 24 :zzz: 14 :x:
For more details on these failures, see this check.
Results for commit 4a99969b.
:recycle: This comment has been updated with latest results.
Codecov Report
Attention: Patch coverage is 93.75000%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 83.85%. Comparing base (
bfef7f0
) to head (d45468f
).
Files | Patch % | Lines |
---|---|---|
rollout/experiment.go | 60.00% | 1 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #3544 +/- ##
==========================================
- Coverage 83.86% 83.85% -0.01%
==========================================
Files 163 163
Lines 18560 18577 +17
==========================================
+ Hits 15565 15578 +13
- Misses 2121 2123 +2
- Partials 874 876 +2
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Codecov Report
Attention: Patch coverage is
81.25000%
with6 lines
in your changes are missing coverage. Please review.Project coverage is 78.20%. Comparing base (
8405f2e
) to head (74a6051
). Report is 99 commits behind head on master.Files Patch % Lines experiments/experiment.go 85.18% 3 Missing and 1 partial ⚠️ rollout/experiment.go 60.00% 1 Missing and 1 partial ⚠️ Additional details and impacted files
@@ Coverage Diff @@ ## master #3544 +/- ## ========================================== - Coverage 81.83% 78.20% -3.64% ========================================== Files 135 158 +23 Lines 20688 18414 -2274 ========================================== - Hits 16931 14400 -2531 - Misses 2883 3105 +222 - Partials 874 909 +35
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.
👋 @zachaller not sure why the code coverage dropped. I added an e2e test that covers the new code paths 🤔
Quality Gate passed
Issues
1 New issue
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
Published E2E Test Results
4 files 4 suites 0s :stopwatch: 1 tests 0 :white_check_mark: 0 :zzz: 1 :x: 0 runs -4 :white_check_mark: 0 :zzz: 4 :x:
For more details on these failures, see this check.
Results for commit 1a0a89af.
:recycle: This comment has been updated with latest results.
Published Unit Test Results
2 261 tests 2 259 :white_check_mark: 2m 56s :stopwatch: 128 suites 0 :zzz: 1 files 2 :x:
For more details on these failures, see this check.
Results for commit 1a0a89af.
:recycle: This comment has been updated with latest results.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code