argo-rollouts icon indicating copy to clipboard operation
argo-rollouts copied to clipboard

chore: Update cloudwatch module to v1.38.0

Open zhaque44 opened this issue 10 months ago • 5 comments

Updating to the newest version available, being proactive:

https://deps.dev/go/github.com%2Faws%2Faws-sdk-go-v2%2Fservice%2Fcloudwatch/v1.38.0

Checklist:

  • [ ] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • [ ] The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • [x] I've signed my commits with DCO
  • [ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • [x] My builds are green. Try syncing with master if they are not.
  • [ ] My organization is added to USERS.md.

zhaque44 avatar Apr 23 '24 16:04 zhaque44

Go Published Test Results

2 160 tests   2 160 :white_check_mark:  2m 53s :stopwatch:   119 suites      0 :zzz:     1 files        0 :x:

Results for commit 49175125.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Apr 23 '24 16:04 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.19%. Comparing base (8405f2e) to head (4917512). Report is 99 commits behind head on master.

:exclamation: Current head 4917512 differs from pull request most recent head dacd084. Consider uploading reports for the commit dacd084 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3538      +/-   ##
==========================================
- Coverage   81.83%   78.19%   -3.65%     
==========================================
  Files         135      158      +23     
  Lines       20688    18397    -2291     
==========================================
- Hits        16931    14386    -2545     
- Misses       2883     3104     +221     
- Partials      874      907      +33     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 23 '24 16:04 codecov[bot]

E2E Tests Published Test Results

  4 files    4 suites   3h 15m 22s :stopwatch: 110 tests  87 :white_check_mark:  6 :zzz: 17 :x: 418 runs  359 :white_check_mark: 22 :zzz: 37 :x:

For more details on these failures, see this check.

Results for commit 49175125.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Apr 23 '24 17:04 github-actions[bot]

@zachaller question, it’s saying the code coverage decreased from updating the go.mod and running tidy on it

zhaque44 avatar Apr 23 '24 22:04 zhaque44

whoops, i relaized dependabot already had an PR for this: @zachaller closing

zhaque44 avatar Apr 30 '24 18:04 zhaque44