argo-rollouts icon indicating copy to clipboard operation
argo-rollouts copied to clipboard
verified publisher icon argoproj

status.observedGeneration field violates type convention

Open isugimpy opened this issue 2 years ago • 3 comments

Checklist:

  • [x] I've included steps to reproduce the bug.
  • [x] I've included the version of argo rollouts.

Describe the bug

Interactions with the status.observedGeneration field on Rollouts behave unexpectedly because the field is forced to be a string rather than an integer on the CRD. This leads to incompatibilities with tooling which observe that field to ensure state of an object. This is particularly frustrating when trying to use Rollouts resources with FluxCD.

To Reproduce

  1. Create a Rollout
  2. Get the Rollout from the API
  3. Observe that the value of status.observedGeneration is in quotes

Expected behavior

The status.observedGeneration field should be an integer in the CRD and represented internally in the controller code as an int64, matching convention of upstream.

Screenshots

N/A

Version

1.6.6

Logs

No relevant logs.

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

isugimpy avatar Feb 26 '24 23:02 isugimpy

I am asking to fix it, almost the half a year passed - no motion and another colleague was hit by this bug:

https://cloud-native.slack.com/archives/CLAJ40HV3/p1728910929113889

gecube avatar Oct 14 '24 17:10 gecube

FWIW, I submitted a PR here #4384

brito-rafa avatar Aug 02 '25 22:08 brito-rafa

Hello, is there a planned date for the 1.9 version ? We have the same issue with FluxCD 😅

Fcornaire avatar Sep 18 '25 07:09 Fcornaire