argo-rollouts
argo-rollouts copied to clipboard
feat: Support AnalysisRunMetadata and Dryrun for experiments via Rollout
Fixes #3209
Checklist:
- [x] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
- [x] The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g.
"fix(controller): Updates such and such. Fixes #1234"
. - [x] I've signed my commits with DCO
- [x] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
- [x] My builds are green. Try syncing with master if they are not.
- [x] My organization is added to USERS.md.
Codecov Report
Attention: 9 lines
in your changes are missing coverage. Please review.
Comparison is base (
c492b06
) 81.82% compared to head (a13bc53
) 81.86%.
Files | Patch % | Lines |
---|---|---|
experiments/experiment.go | 80.55% | 5 Missing and 2 partials :warning: |
rollout/analysis.go | 80.00% | 1 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #3213 +/- ##
==========================================
+ Coverage 81.82% 81.86% +0.03%
==========================================
Files 135 135
Lines 20688 20712 +24
==========================================
+ Hits 16928 16955 +27
+ Misses 2886 2883 -3
Partials 874 874
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Go Published Test Results
2 109 tests 2 109 :white_check_mark: 2m 50s :stopwatch: 118 suites 0 :zzz: 1 files 0 :x:
Results for commit a13bc533.
:recycle: This comment has been updated with latest results.
E2E Tests Published Test Results
4 files 4 suites 3h 27m 8s :stopwatch: 106 tests 95 :white_check_mark: 6 :zzz: 5 :x: 436 runs 401 :white_check_mark: 24 :zzz: 11 :x:
For more details on these failures, see this check.
Results for commit a13bc533.
:recycle: This comment has been updated with latest results.
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells
No Coverage information
4.8% Duplication
Hi @zachaller , Can I please get a review on this one ?
Hi @zachaller , could I get a review on this one ?
Quality Gate passed
The SonarCloud Quality Gate passed, but some issues were introduced.
4 New issues
0 Security Hotspots
No data about Coverage
31.9% Duplication on New Code