Rollout stucks when stable revision is ReplicaFailure

[erkanzileli]

Checklist:

• [x] I've included steps to reproduce the bug.
• [x] I've included the version of argo rollouts.

Describe the bug

Rollout status gets stuck when the stable revision is ReplicaFailure and the canary revision is Healthy

To Reproduce

Anything that fails the ReplicaSet would work. The first revision must fail to reproduce this issue

Expected behavior

When the stable has no Pods and the canary is fine, it should promote it automatically

Screenshots

The first revision failed because of ReplicaFailure

The image below shows that we created a healthy revision, but it's stuck because of the previous failed stable revision.

Version

1.4.0 and 1.6.0

---

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

@galetis

[perek]

👍 this is a issue with all canary deployments though, I believe argo should not consider a broken stable (especially on initial rollout) a failure curing canary stage.