fix(analysis): Make AnalysisRun end when only Dry-Run metrics are defined. Fixes: #2151

[agrawroh]

Description

This PR fixes the issue defined in https://github.com/argoproj/argo-rollouts/issues/2151 where AnalysisRun doesn't transition to Successful from Running when only Dry-Run metrics are defined and being evaluated. As per the current logic, we don't set the decision while evaluating the Dry-Run metrics but the proper fix is to set it to Successful at least if nothing is set.

Checklist

• [x] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
• [x] The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
• [x] I've signed my commits with DCO
• [x] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• [x] My builds are green. Try syncing with master if they are not.
• [x] My organization is added to USERS.md.

[github-actions[bot]]

Go Published Test Results

1 769 tests   1 769 :heavy_check_mark:  2m 34s :stopwatch:    101 suites         0 :zzz:        1 files           0 :x:

Results for commit 49df77fe.

:recycle: This comment has been updated with latest results.

[github-actions[bot]]

E2E Tests Published Test Results

  1 files    1 suites   46m 21s :stopwatch: 89 tests 84 :heavy_check_mark: 3 :zzz: 2 :x: 91 runs  86 :heavy_check_mark: 3 :zzz: 2 :x:

For more details on these failures, see this check.

Results for commit 49df77fe.

:recycle: This comment has been updated with latest results.

[codecov[bot]]

Codecov Report

Base: 82.35% // Head: 82.36% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (49df77f) compared to base (e646371). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2230   +/-   ##
=======================================
  Coverage   82.35%   82.36%           
=======================================
  Files         121      121           
  Lines       18434    18438    +4     
=======================================
+ Hits        15182    15186    +4     
  Misses       2466     2466           
  Partials      786      786           

Impacted Files	Coverage Δ
analysis/analysis.go	85.53% <100.00%> (+0.10%)	:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

[sonarqubecloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
9.2% Duplication

[chrisplim]

@agrawroh thanks for the fix and @harikrongali thanks for the review!