argo-rollouts
argo-rollouts copied to clipboard
feat: Allow Traffic shaping through header based routing ALB
Signed-off-by: Andrii Perenesenko [email protected]
Checklist:
- [x] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
- [x] The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g.
"fix(controller): Updates such and such. Fixes #1234"
. - [x] I've signed my commits with DCO
- [x] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
- [ ] My builds are green. Try syncing with master if they are not.
- [x] My organization is added to USERS.md.
Codecov Report
Merging #2061 (a994c78) into master (3329626) will decrease coverage by
0.35%
. The diff coverage is52.32%
.
:exclamation: Current head a994c78 differs from pull request most recent head bd971dd. Consider uploading reports for the commit bd971dd to get more accurate results
@@ Coverage Diff @@
## master #2061 +/- ##
==========================================
- Coverage 82.24% 81.88% -0.36%
==========================================
Files 121 120 -1
Lines 17956 17673 -283
==========================================
- Hits 14768 14472 -296
- Misses 2419 2487 +68
+ Partials 769 714 -55
Impacted Files | Coverage Δ | |
---|---|---|
utils/defaults/defaults.go | 84.86% <0.00%> (-3.80%) |
:arrow_down: |
rollout/trafficrouting/alb/alb.go | 55.45% <17.32%> (-27.66%) |
:arrow_down: |
utils/ingress/ingress.go | 92.14% <25.00%> (-7.86%) |
:arrow_down: |
ingress/alb.go | 91.30% <82.60%> (-5.25%) |
:arrow_down: |
pkg/apis/rollouts/validation/validation.go | 94.80% <94.44%> (-0.87%) |
:arrow_down: |
utils/ingress/wrapper.go | 91.43% <97.64%> (+2.18%) |
:arrow_up: |
utils/unstructured/unstructured.go | 55.93% <0.00%> (-18.40%) |
:arrow_down: |
rollout/trafficrouting/traefik/traefik.go | 79.59% <0.00%> (-2.77%) |
:arrow_down: |
rollout/trafficrouting/istio/controller.go | 50.81% <0.00%> (-1.63%) |
:arrow_down: |
... and 21 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3329626...bd971dd. Read the comment docs.
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
12 Code Smells
No Coverage information
3.9% Duplication
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
10 Code Smells
No Coverage information
6.3% Duplication
Go Published Test Results
0 tests 0 :heavy_check_mark: 0s :stopwatch: 0 suites 0 :zzz: 0 files 0 :x:
Results for commit bd971dd5.
E2E Tests Published Test Results
0 tests 0 :heavy_check_mark: 0s :stopwatch: 0 suites 0 :zzz: 1 files 0 :x:
Results for commit bd971dd5.
@perenesenko - Why did you close this PR? We have a sceario where argo-rollouts is controlling an ALB, but we want requests from out test clients to always go to canary pods. Is there another way to do this?
@ssanders1449 this was done in https://github.com/argoproj/argo-rollouts/pull/2214
Can you provide an example like this? There were some issues with my testing here
Is there any documentation for it? Thanks!