argo-rollouts icon indicating copy to clipboard operation
argo-rollouts copied to clipboard

chore: remove deprecated -i for go build

Open danielhelfand opened this issue 2 years ago • 2 comments

The -i flag installs the packages that are dependencies of the target.
The -i flag is deprecated. Compiled packages are cached automatically.

Checklist:

  • [ ] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • [ ] The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • [ ] I've signed my commits with DCO
  • [ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • [ ] My builds are green. Try syncing with master if they are not.
  • [ ] My organization is added to USERS.md.

danielhelfand avatar May 18 '22 20:05 danielhelfand

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar May 18 '22 20:05 sonarqubecloud[bot]

Codecov Report

Base: 81.55% // Head: 81.55% // No change to project coverage :thumbsup:

Coverage data is based on head (825a03b) compared to base (3aa87aa). Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2047   +/-   ##
=======================================
  Coverage   81.55%   81.55%           
=======================================
  Files         124      124           
  Lines       18929    18929           
=======================================
  Hits        15437    15437           
  Misses       2702     2702           
  Partials      790      790           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar May 18 '22 20:05 codecov[bot]

This PR is stale because it has been open 90 days with no activity.

github-actions[bot] avatar Oct 21 '22 03:10 github-actions[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.1% 3.1% Duplication

sonarqubecloud[bot] avatar Nov 08 '22 18:11 sonarqubecloud[bot]

Go Published Test Results

1 798 tests   1 798 :heavy_check_mark:  2m 31s :stopwatch:    102 suites         0 :zzz:        1 files           0 :x:

Results for commit 825a03b3.

github-actions[bot] avatar Nov 08 '22 19:11 github-actions[bot]

E2E Tests Published Test Results

    2 files      2 suites   1h 28m 22s :stopwatch:   89 tests   86 :heavy_check_mark: 3 :zzz: 0 :x: 178 runs  172 :heavy_check_mark: 6 :zzz: 0 :x:

Results for commit 825a03b3.

github-actions[bot] avatar Nov 08 '22 19:11 github-actions[bot]