argo-rollouts icon indicating copy to clipboard operation
argo-rollouts copied to clipboard

chore: add arm64 for darwin plugin to Makefile

Open danielhelfand opened this issue 2 years ago • 2 comments

Checklist:

  • [ ] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • [ ] The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • [ ] I've signed my commits with DCO
  • [ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • [ ] My builds are green. Try syncing with master if they are not.
  • [ ] My organization is added to USERS.md.

danielhelfand avatar May 16 '22 15:05 danielhelfand

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar May 16 '22 15:05 sonarqubecloud[bot]

Codecov Report

Merging #2036 (618344e) into master (59f949c) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2036   +/-   ##
=======================================
  Coverage   82.50%   82.50%           
=======================================
  Files         120      120           
  Lines       17054    17054           
=======================================
  Hits        14070    14070           
  Misses       2283     2283           
  Partials      701      701           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 59f949c...618344e. Read the comment docs.

codecov[bot] avatar May 16 '22 15:05 codecov[bot]

Hi! what is the status of this? it is gonna be merged? 🙏

mknet3 avatar Sep 26 '22 15:09 mknet3

I want to superced this with https://github.com/argoproj/argo-rollouts/pull/2264 to add support for releases as well

zachaller avatar Sep 26 '22 15:09 zachaller

Perfect! Thanks @zachaller

mknet3 avatar Sep 26 '22 15:09 mknet3