argo-rollouts icon indicating copy to clipboard operation
argo-rollouts copied to clipboard

docs: common questions for Rollbacks

Open kostis-codefresh opened this issue 2 years ago • 4 comments

Signed-off-by: Kostis Kapelonis [email protected]

Answering some questions for rollbacks that I see multiple people asking over and over in the Slack channels.

Checklist:

  • [X] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • [X] The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • [X] I've signed my commits with DCO
  • [ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • [ ] My builds are green. Try syncing with master if they are not.
  • [ ] My organization is added to USERS.md.

kostis-codefresh avatar May 09 '22 11:05 kostis-codefresh

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarcloud[bot] avatar May 09 '22 11:05 sonarcloud[bot]

Codecov Report

Merging #2027 (20ed27d) into master (59f949c) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2027   +/-   ##
=======================================
  Coverage   82.50%   82.50%           
=======================================
  Files         120      120           
  Lines       17054    17054           
=======================================
  Hits        14070    14070           
  Misses       2283     2283           
  Partials      701      701           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 59f949c...20ed27d. Read the comment docs.

codecov[bot] avatar May 09 '22 11:05 codecov[bot]

Would you mind adding a comment about low traffic canary services to avoid inconclusive releases (and might cause a rollback) where metrics are not generated due to 0 or low traffic?

Perhaps an example with parallel smoke tests with the duration of the projected canary?

pragmaticivan avatar May 11 '22 01:05 pragmaticivan

@pragmaticivan Any examples that you are interested in should go on a separate PR. That being said, if you think that the FAQ for rollbacks should be extended, I think it is best to open your own PR and discuss it there. I prefer to focus on a single thing on each PR.

kostis-codefresh avatar May 11 '22 07:05 kostis-codefresh