argo-rollouts
argo-rollouts copied to clipboard
docs: add available configuration options for rollouts controller. Fixes #1914
It seems that docs are not listing available configuration options for the controller, this is a just simple attempt to list options as in ArgoCD Server Configuration Parameters docs.
Refs: #1914 Signed-off-by: Celal Öner [email protected]
Checklist:
- [x] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
- [x] The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g.
"fix(controller): Updates such and such. Fixes #1234"
. - [x] I've signed my commits with DCO
- [ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
- [x] My builds are green. Try syncing with master if they are not.
- [ ] My organization is added to USERS.md.
Codecov Report
Base: 81.55% // Head: 82.42% // Increases project coverage by +0.86%
:tada:
Coverage data is based on head (
c26e78d
) compared to base (93c2520
). Patch has no changes to coverable lines.
:exclamation: Current head c26e78d differs from pull request most recent head 9e44a75. Consider uploading reports for the commit 9e44a75 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## master #1921 +/- ##
==========================================
+ Coverage 81.55% 82.42% +0.86%
==========================================
Files 124 119 -5
Lines 18931 16913 -2018
==========================================
- Hits 15439 13940 -1499
+ Misses 2702 2282 -420
+ Partials 790 691 -99
Impacted Files | Coverage Δ | |
---|---|---|
utils/unstructured/unstructured.go | 55.93% <0.00%> (-18.40%) |
:arrow_down: |
pkg/kubectl-argo-rollouts/cmd/lint/lint.go | 67.90% <0.00%> (-17.95%) |
:arrow_down: |
ingress/ingress.go | 60.60% <0.00%> (-13.40%) |
:arrow_down: |
service/service.go | 68.37% <0.00%> (-10.14%) |
:arrow_down: |
analysis/controller.go | 52.17% <0.00%> (-9.37%) |
:arrow_down: |
pkg/kubectl-argo-rollouts/info/analysisrun_info.go | 82.60% <0.00%> (-7.40%) |
:arrow_down: |
experiments/controller.go | 67.28% <0.00%> (-4.14%) |
:arrow_down: |
utils/replicaset/canary.go | 89.26% <0.00%> (-3.46%) |
:arrow_down: |
utils/ingress/wrapper.go | 89.25% <0.00%> (-3.08%) |
:arrow_down: |
rollout/controller.go | 77.75% <0.00%> (-3.02%) |
:arrow_down: |
... and 51 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
This PR is stale because it has been open 90 days with no activity.
Hi everyone, I tried to update the branch and apply all the pr suggestions. Could you review it again when you have time and merge it if it is okay for the project?
Go Published Test Results
1 798 tests 1 798 :heavy_check_mark: 2m 32s :stopwatch: 102 suites 0 :zzz: 1 files 0 :x:
Results for commit 9e44a755.
E2E Tests Published Test Results
2 files 2 suites 1h 31m 25s :stopwatch: 89 tests 84 :heavy_check_mark: 3 :zzz: 2 :x: 180 runs 172 :heavy_check_mark: 6 :zzz: 2 :x:
For more details on these failures, see this check.
Results for commit 9e44a755.
Thanks to everyone who helped in the past. I'm closing this pr, it seems that there will be no activity for this pr.