argo-rollouts icon indicating copy to clipboard operation
argo-rollouts copied to clipboard

Published 20 hours ago • verified publisher icon argoproj

Gateway API support for Argo rollouts

Open mark-church opened this issue 3 years ago • 7 comments

Gateway API is a standard out of SIG-Network that evolves the ingress interface with more advanced capabilities such as weight-based load balancing. There are already many Gateway API implementations that exist including Kong, Traefik, Istio, GKE, and more. This tutorial shows how traffic splitting works in Gateway.

This issue is to propose Gateway API-based support for Argo rollouts so that any Gateway API implementation can be used with Argo in the same way.

cc @bowei @robscott

mark-church avatar Aug 23 '21 01:08 mark-church

As with our support for SMI, this makes perfect sense to me, and would help to alleviate the many direct integration requests that we often get.

jessesuen avatar Aug 23 '21 18:08 jessesuen

I would like to implement it

PhilippPlotnikov avatar Mar 17 '22 10:03 PhilippPlotnikov

Thank you @PhilippPlotnikov

alexmt avatar Mar 17 '22 15:03 alexmt

would it be possible to support KrakenD api gateway for argo rollouts as well?

mainey avatar Mar 31 '22 10:03 mainey

My apologies if "me too"s aren't appropriate for issues here, but we (Dexcare) are very interested in a Gateway API implementation in Argo Rollouts. @PhilippPlotnikov , is there a way that we can track progress on this? I may be able to contribute some testing time in our development environment.

object88 avatar Apr 04 '22 16:04 object88

@object88 yes, of course https://github.com/argoproj/argo-rollouts/pull/2004. Here I have made the support but without tests, Im in process. I tested locally it works.

PhilippPlotnikov avatar Apr 27 '22 07:04 PhilippPlotnikov

I have finished PR with Gateway API support, can someone review it please ? https://github.com/argoproj/argo-rollouts/pull/2004

PhilippPlotnikov avatar May 26 '22 11:05 PhilippPlotnikov

Hi, I have implemented Gateway API plugin, you can try to test it https://github.com/argoproj-labs/rollouts-gatewayapi-trafficrouter-plugin

PhilippPlotnikov avatar Mar 10 '23 19:03 PhilippPlotnikov

This is great @PhilippPlotnikov, thanks! Would welcome a PR to reference this on Gateway API's documentation: https://gateway-api.sigs.k8s.io/implementations/#integration-status.

robscott avatar Mar 11 '23 01:03 robscott

@robscott hi! Sure, I will try to create PR on the next week

PhilippPlotnikov avatar Mar 12 '23 18:03 PhilippPlotnikov

@robscott PR is here https://github.com/kubernetes-sigs/gateway-api/pull/1836

kostis-codefresh avatar Mar 17 '23 13:03 kostis-codefresh

@zachaller

We have now tested three independent implementations for Gateway API and they all work just fine with the plugin

I suggest we mark this issue as closed.

kostis-codefresh avatar Jun 02 '23 08:06 kostis-codefresh

@object88 if you have time for testing, it would be great to add more examples in the plugin repositories with different implementations of the Gateway API

kostis-codefresh avatar Jun 02 '23 08:06 kostis-codefresh

Closing because it is implemented as a plugin

zachaller avatar Jul 10 '23 14:07 zachaller