argo-helm icon indicating copy to clipboard operation
argo-helm copied to clipboard

[argo-cd] Add note about argocdServerAdminPassword when deployed through ArgoCD

Open mkilchhofer opened this issue 3 years ago • 4 comments

Follow-up issue of #784

When deploying the argo-cd chart via an ArgoCD instance, we need to take care how we inject the argocdServerAdminPassword. If we define it like this:

apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
  name: argocd-testing
spec:
  destination:
    namespace: testing
    server: https://kubernetes.default.svc
  project: default
  source:
    chart: argo-cd
    repoURL: https://argoproj.github.io/argo-helm
    targetRevision: 3.21.0
    helm:
      parameters:
      - name: configs.secret.argocdServerAdminPassword
        value: $2a$10$H1a30nMr9v2QE2nkyz0BoOD2J0I6FQFMtHS0csEg12RBWzfRuuoE6

It does not work because ArgoCD uses variable substitution in the parameters section.

However, if we define it in the values section, this works as expected:

apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
  name: argocd-testing
spec:
  destination:
    namespace: testing
    server: https://kubernetes.default.svc
  project: default
  source:
    chart: argo-cd
    repoURL: https://argoproj.github.io/argo-helm
    targetRevision: 3.21.0
    helm:
      values: |
        configs:
          secret:
            argocdServerAdminPassword: $2a$10$H1a30nMr9v2QE2nkyz0BoOD2J0I6FQFMtHS0csEg12RBWzfRuuoE6

We should at least place a hint inside the Chart's README.md

mkilchhofer avatar Jun 03 '21 14:06 mkilchhofer

Stale issue message

github-actions[bot] avatar Aug 07 '21 02:08 github-actions[bot]

not stale

mkilchhofer avatar Aug 12 '21 07:08 mkilchhofer

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Nov 26 '21 02:11 github-actions[bot]

same issue

Jojoooo1 avatar Feb 17 '23 16:02 Jojoooo1