argoproj
argo-cd: commit-server wrong DNS name
Describe the bug
argo-cd chart v8.0.14. With these values.yaml:
configs:
params:
hydrator.enabled: true
commitServer:
enabled: true
And using hydrator as documented at https://argo-cd.readthedocs.io/en/release-3.0/user-guide/source-hydrator/ this error is seen on sync (even after restarting appropriate pods):
"transport: Error while dialing: dial tcp: lookup argocd-commit-server on 10.96.0.10:53: no such host"
The proper name is argo-cd-argocd-commit-server.
Adding this to the application StatefulSet template.spec.containers.env fixes it.
- name: ARGOCD_APPLICATION_CONTROLLER_COMMIT_SERVER
value: argo-cd-argocd-commit-server:8086
I think this is what is wanted but I did not test.
diff --git charts/argo-cd/templates/argocd-application-controller/statefulset.yaml charts/argo-cd/templates/argocd-application-controller/statefulset.yaml
index 02c51806..418bb6b7 100644
--- charts/argo-cd/templates/argocd-application-controller/statefulset.yaml
+++ charts/argo-cd/templates/argocd-application-controller/statefulset.yaml
@@ -84,6 +84,8 @@ spec:
value: {{ .Values.controller.replicas | quote }}
- name: ARGOCD_APPLICATION_CONTROLLER_NAME
value: {{ template "argo-cd.controller.fullname" . }}
+ - name: ARGOCD_APPLICATION_CONTROLLER_COMMIT_SERVER
+ value: {{ template "argo-cd.commitServer.fullname" . }}:8086
- name: ARGOCD_RECONCILIATION_TIMEOUT
valueFrom:
configMapKeyRef:
Related helm chart
argo-cd
Helm chart version
8.0.14
To Reproduce
See above
Expected behavior
No DNS error.
Screenshots
No response
Additional context
No response
Hi @bdrewery , we follow upstream's manifest and ARGOCD_APPLICATION_CONTROLLER_COMMIT_SERVER is not configured for now.
Please add the env in upstream's manifest, so we will follow. 🙏
https://github.com/search?q=repo%3Aargoproj%2Fargo-cd%20ARGOCD_APPLICATION_CONTROLLER_COMMIT_SERVER&type=code
I'll happily help get a PR through upstream and here. It just may take me a week or more to find time. If someone wants to do it before me that's cool too. This looks like an easy first contribution kind of issue, if there is such a label to add.
@yu-croco Is fixed as of https://github.com/argoproj/argo-cd/commit/e9811678fac83619850600f424424a504dd577c9 .
When upstream releases the diff as specific version, we will update manifest as following upstream. So please wait for it.