argo-helm icon indicating copy to clipboard operation
argo-helm copied to clipboard

feat(argo-cd): Generate crd from upstream

Open DrFaust92 opened this issue 3 months ago • 6 comments

Closes https://github.com/argoproj/argo-helm/issues/2613

Checklist:

  • [x] I have bumped the chart version according to versioning
  • [x] I have updated the documentation according to documentation
  • [x] I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • [x] Any new values are backwards compatible and/or have sensible default.
  • [x] I have signed off all my commits as required by DCO.
  • [x] My build is green (troubleshooting builds).

DrFaust92 avatar Mar 29 '24 15:03 DrFaust92

need to fix this to support the custom templating (annotations and if to enable crd) and this should be good. but i would love to get input from maintainer if this is a valid approach.

@jmeridth @pdrastil @yu-croco , what do you think?

DrFaust92 avatar Mar 29 '24 15:03 DrFaust92

Hi @DrFaust92 , thank you for your PR. IMO:

  • Auto generation of CRD sounds nice to me.
  • In addition to support .Values.crds.xxxx , it's also nice to run this script when Renovate bumps version. 👍

@mbevc1 @mkilchhofer@jmeridth @pdrastil @tico24 WDYT? 🙋

yu-croco avatar Apr 02 '24 23:04 yu-croco

@yu-croco Sounds OK, however upstream do not have templating on CRD resources / additional conditional block we have. You can see removed sections in PR. In both cases auto-generation or manual sync I always have to modify these sections by hand.

pdrastil avatar Apr 03 '24 08:04 pdrastil

@pdrastil I'll add logic to template this, just wanted to know if it's worth the effort in the first place 🤗

DrFaust92 avatar Apr 03 '24 08:04 DrFaust92

@DrFaust92 It is - my current process is doing diffs / manual copy & paste of spec based on upstream :)

pdrastil avatar Apr 03 '24 08:04 pdrastil

Maybe we need some yq logic to only copy over the CRD.spec?🤣

mkilchhofer avatar Apr 03 '24 09:04 mkilchhofer