argo-helm icon indicating copy to clipboard operation
argo-helm copied to clipboard

Allow setting resource inclusion/exclusion

Open aqeelat opened this issue 2 years ago • 4 comments

Is your feature request related to a problem?

Since it is part of the declarative setup, it would be useful to add it to the chart as well

https://argo-cd.readthedocs.io/en/stable/operator-manual/declarative-setup/#resource-exclusioninclusion

Related helm chart

argo-cd

Describe the solution you'd like

Adding an option for it in values.yaml

Describe alternatives you've considered

No response

Additional context

No response

aqeelat avatar Mar 19 '24 21:03 aqeelat

Hi @aqeelat , thank you for your issue. I will make PR for this.

FYI: The following works well for now, it's just not declared in values.yaml though. :)

configs:
  cm:
    resource.exclusions: |
      - apiGroups:
        - "*"
        kinds:
        - "*"
        clusters:
        - https://192.168.0.20

yu-croco avatar Mar 20 '24 00:03 yu-croco

Hi @yu-croco - the key is not part of CM as there is link to upstream with all supported attributes. The exclusions really depends what you have in cluster (crossplane, external-secrets, kyverno, etc. are typically here).

pdrastil avatar Mar 20 '24 09:03 pdrastil

Hi @pdrastil , thank you for your comment. doc says to edit the argocd-cm for the feature, so I thought we could handle with it.... 👀

To configure this, edit the argocd-cm config map:

https://argo-cd.readthedocs.io/en/stable/operator-manual/declarative-setup/#resource-exclusioninclusion

yu-croco avatar Mar 20 '24 09:03 yu-croco

We also had issues with this while upgrading. I think moving this config to .Values.configs.cm makes sense, but without seeing this issue or looking here, I'm not sure how users are know that .Values.server.config was broken. Happy to help if this should be backwards compatible.

bsteinm2 avatar Mar 21 '24 17:03 bsteinm2

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar May 21 '24 02:05 github-actions[bot]