argo-helm icon indicating copy to clipboard operation
argo-helm copied to clipboard

feat(argo-rollouts): Restrict write access to rollout status in the aggregated roles

Open nedal87 opened this issue 4 months ago • 1 comments

The status subresource is typically managed automatically by the controller managing the resource, in this case, the Argo Rollouts controller. Allowing users to directly manipulate the status subresource could lead to inconsistencies and unintended behavior, as the controller might overwrite or ignore manually set status updates.

Therefore, it's generally a good practice to restrict permissions to modify the status subresource to the controller or system components responsible for managing the resource, rather than granting such permissions to users directly. This helps ensure the integrity and consistency of the resource's state. After this change, users will be still able to view the rollout status.

Current setup: argo-rollouts:edit

Checklist:

  • [x] I have bumped the chart version according to versioning
  • [x] I have updated the documentation according to documentation
  • [x] I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • [x] Any new values are backwards compatible and/or have sensible default.
  • [x] I have signed off all my commits as required by DCO.
  • [ ] My build is green (troubleshooting builds).

nedal87 avatar Feb 21 '24 13:02 nedal87

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Apr 27 '24 02:04 github-actions[bot]