argo-helm icon indicating copy to clipboard operation
argo-helm copied to clipboard

feat(argo-cd): Add `existingVolumes` setting for remaining deployments with emptyDir volumes

Open bodgit opened this issue 5 months ago • 6 comments

#2410 added the existingVolumes setting for the repo-server component. This PR adds an equivalent setting to the other Argo CD components that have emptyDir volumes in their deployment so you can either use a PVC or further tune the emptyDir volume with sizeLimit parameters, etc. (which is what I do).

Checklist:

  • [x] I have bumped the chart version according to versioning
  • [x] I have updated the documentation according to documentation
  • [x] I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • [x] Any new values are backwards compatible and/or have sensible default.
  • [x] I have signed off all my commits as required by DCO.
  • [x] My build is green (troubleshooting builds).

bodgit avatar Jan 26 '24 15:01 bodgit

FYI Regarding the failed CI, https://github.com/argoproj/argo-helm/issues/2460 is related. There is a PR for fixing in upstream, let's wait for it.

yu-croco avatar Jan 28 '24 14:01 yu-croco

FYI: The CI is fixed now. 👍

yu-croco avatar Jan 29 '24 13:01 yu-croco

@yu-croco Rebased and all tests now pass.

bodgit avatar Jan 30 '24 09:01 bodgit

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Apr 06 '24 02:04 github-actions[bot]

Probably needs rebasing rather than closing? :thinking:

mbevc1 avatar Apr 14 '24 13:04 mbevc1

Hi @bodgit , can you please fetch latest remote diff and resolve conflicts?

yu-croco avatar Apr 16 '24 08:04 yu-croco