argo-helm
argo-helm copied to clipboard
feat(argocd-apps): support ignoreApplicationDifferences for appsets
Checklist:
- [x] I have bumped the chart version according to versioning
- [x] I have updated the documentation according to documentation
- [x] I have updated the chart changelog with all the changes that come with this pull request according to changelog.
- [x] Any new values are backwards compatible and/or have sensible default.
- [x] I have signed off all my commits as required by DCO.
- [ ] My build is green (troubleshooting builds).
@yu-croco thank you for the prompt review, added the requested changes
This is a puzzling. The test is supposed to check the functionality of the argocd-apps chart, but it fails on some other charts that are not directly related.
Installing chart with values file "charts/argocd-apps/ci/extensions-values.yaml"...
Creating namespace "argocd-apps-re9ctpz5xl"... namespace/argocd-apps-re9ctpz5xl created Error: INSTALLATION FAILED: unable to build kubernetes objects from release manifest: resource mapping not found for name: "example" namespace: "default" from "": no matches for kind "ArgoCDExtension" in version "argoproj.io/v1alpha1" ensure CRDs are installed first
argocd-apps/ci/extensions-values.yaml has problem... 👀 CI Ref: https://github.com/argoproj/argo-helm/actions/runs/7618206138/job/20753238610?pr=2442
Since Argo CD Extensions is deprecated now, I wonder we don't need support this so eagerly, which means we can remove argocd-apps/ci/extensions-values.yaml...? 🤔
@mkilchhofer @jmeridth What do you think about this? 🤔
[updated] I wondered we should make other PR to remove Argo CD Extensions (and adopt latest one?) from argocd-apps at first.
I made PR for failed CI, https://github.com/argoproj/argo-helm/pull/2449 . 🙋
Hi @imranismail , please fetch latest diff and you can pass the CI. :)