argo-helm icon indicating copy to clipboard operation
argo-helm copied to clipboard

feat(argo-rollouts): Add configurable deployment strategy for Argo Rollouts controller

Open nedal87 opened this issue 2 years ago • 2 comments

Added configurable deployment strategy for the Argo Rollouts controller. Users can now specify either "Recreate" or "RollingUpdate" as the deployment strategy in the values.yaml file. This enhancement provides users with flexibility in choosing the deployment strategy that best suits their needs.

Checklist:

  • [x] I have bumped the chart version according to versioning
  • [x] I have updated the documentation according to documentation
  • [x] I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • [x] Any new values are backwards compatible and/or have sensible default.
  • [x] I have signed off all my commits as required by DCO.
  • [ ] My build is green (troubleshooting builds).

nedal87 avatar Jan 05 '24 01:01 nedal87

Hello folks!. Thanks for the contribution. Any idea when this change will be published?

CarlosLanderas avatar Mar 20 '24 08:03 CarlosLanderas

Any idea when this change will be published?

Hi @CarlosLanderas , we can merge when upstream merge https://github.com/argoproj/argo-rollouts/pull/3334 into specific new version because we follow upstresm's manifest. If you are really hurry, you may mention in upstream.

yu-croco avatar Mar 20 '24 09:03 yu-croco

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar May 20 '24 02:05 github-actions[bot]

Hi @nedal87 , the deployment strategy has changed in upstream in v1.7.0 and argo-helm also released it https://github.com/argoproj/argo-helm/pull/2763 . Let's resume this PR. 🚀

yu-croco avatar Jun 14 '24 09:06 yu-croco