argo-helm icon indicating copy to clipboard operation
argo-helm copied to clipboard

feat(argo-cd): Support new `k8sclient.retry` options

Open llavaud opened this issue 7 months ago • 8 comments

add support for the new following controller/server parameters introduce in the 2.9.0 (https://github.com/argoproj/argo-cd/pull/16154) version:

  • controller.k8sclient.retry.max
  • controller.k8sclient.retry.base.backoff
  • server.k8sclient.retry.max
  • server.k8sclient.retry.base.backoff

Checklist:

  • [x] I have bumped the chart version according to versioning
  • [x] I have updated the documentation according to documentation
  • [x] I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • [x] Any new values are backwards compatible and/or have sensible default.
  • [x] I have signed off all my commits as required by DCO.
  • [x] My build is green (troubleshooting builds).

llavaud avatar Nov 15 '23 13:11 llavaud

Your PR LGTM. Not that I don't believe you, but I can't see the retries stuff actually in v2.9.0 - this is almost certainly because I can't use computers but are you able to reference it for me?

tico24 avatar Nov 15 '23 13:11 tico24

Your PR LGTM. Not that I don't believe you, but I can't see the retries stuff actually in v2.9.0 - this is almost certainly because I can't use computers but are you able to reference it for me?

Here is the related PR: https://github.com/argoproj/argo-cd/pull/16154

llavaud avatar Nov 15 '23 14:11 llavaud

I see the PR. I couldn't see it merged/released to v2.9.x - it seems to be sat on master.

tico24 avatar Nov 15 '23 14:11 tico24

I see the PR. I couldn't see it merged/released to v2.9.x - it seems to be sat on master.

It is in the CHANGELOG, weird...

llavaud avatar Nov 15 '23 14:11 llavaud

I told you I couldn't use computers :)

Cheers for your help.

tico24 avatar Nov 15 '23 14:11 tico24

I told you I couldn't use computers :)

Cheers for your help.

no, you're right, code is not in the 2.9.0 compared to master :(

llavaud avatar Nov 15 '23 14:11 llavaud

Do we want to defer this until upstream releases this? :thinking:

mbevc1 avatar Nov 15 '23 14:11 mbevc1

Do we want to defer this until upstream releases this? 🤔

This would be my personal preference.

tico24 avatar Nov 15 '23 14:11 tico24

Closed as part of 2.10.0 upgrade in https://github.com/argoproj/argo-helm/pull/2476

pdrastil avatar Feb 06 '24 23:02 pdrastil