argo-helm
argo-helm copied to clipboard
fix(argo-cd): Add cluster role to allow a namespaced applicationset to be handled by a controller
I recently enabled the name spacing feature of the application controller and ran into the the issue that the application controller couldn't create/read the applications in the required namespace.
Its probably best to add a cluster role for this case?
Checklist:
- [x] I have bumped the chart version according to versioning
- [x] I have updated the documentation according to documentation
- [x] I have updated the chart changelog with all the changes that come with this pull request according to changelog.
- [x] Any new values are backwards compatible and/or have sensible default.
- [x] I have signed off all my commits as required by DCO.
- [ ] My build is green (troubleshooting builds).
Please fix your PR title to match requirement of
example: fix(argo-cd): blah blah blah
Also please sign all of your commits to pass DCO. Thanks.
Hi @borisssmidtCET , thank you for your PR. Please handle below (items written in PR description).
[ ] I have bumped the chart version according to versioning
-> Please bump patch version.
[ ] I have updated the chart changelog with all the changes that come with this pull request according to changelog.
-> Please remove old ones and add new ones in changelog.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Hi, I think this is still relevant! Is there anything to be done to get this going again?
i will be create pr for that.
https://github.com/argoproj/argo-helm/pull/2402
Closing in favor of #2402 as it has recent interactions and movement. Thank you for contributing @borisssmidtCET.