argo-helm icon indicating copy to clipboard operation
argo-helm copied to clipboard

[argo-workflows] env is incorrectly defaulted to {} instead of [] in a couple of places in values.yaml

Open ramanNarasimhan77 opened this issue 1 year ago • 0 comments

Describe the bug

Found a very minor issue, All Env fields should be defaulted to "[]" instead of "{}'. ExtraEnv fields in values.yaml are defaulted correctly but looks like executor.env & mainContainer.env might need to be corrected to avoid warnings during installation if these fields are set.

Helm emits warnings if .Values.executor.env is set because it is defaulted to a dict in values.yaml here coalesce.go:220: warning: cannot overwrite table with non table for argo-workflows.executor.env (map[])

Similar issue also exists for mainContainer env https://github.com/argoproj/argo-helm/blob/main/charts/argo-workflows/values.yaml#L274

Related helm chart

argo-workflows

Helm chart version

0.17.1

To Reproduce

Install Argo-Workflows with a custom values file which sets executor.env / mainContainer.env with a list

Example:

executor: 
    env:
      - name: SSL_CERT_FILE
        value: /usr/local/share/ca-certificates/ca.crt

Expected behavior

Container env is a list

   env  <[]Object>
     List of environment variables to set in the container. Cannot be updated.

So should be defaulted in the argo-workflows/values.yaml to a list

Screenshots

No response

Additional context

No response

ramanNarasimhan77 avatar Sep 14 '22 07:09 ramanNarasimhan77