argo-helm icon indicating copy to clipboard operation
argo-helm copied to clipboard

fix(argo-workflows): Moving CRDs to the Templates folder

Open christophercutajar opened this issue 3 years ago • 1 comments

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

This PR is related to https://github.com/argoproj/argo-helm/issues/1430. This PR includes:

  • Moving CRDs to the templates folder
  • Adding crds variable in the `values.yaml

Checklist:

  • [x] I have bumped the chart version according to versioning
  • [ ] I have updated the documentation according to documentation
  • [x] I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • [x] Any new values are backwards compatible and/or have sensible default.
  • [x] I have signed off all my commits as required by DCO.
  • [ ] My build is green (troubleshooting builds).

Changes are automatically published when merged to main. They are not published on branches.

christophercutajar avatar Aug 31 '22 15:08 christophercutajar

I think this PR has breaking change for existing users, so we need to describe how to adopt existing CRDs, like https://github.com/argoproj/argo-helm/pull/1342 . 👀

argo-workflows does not have upgrade guid for now, like https://github.com/argoproj/argo-helm/tree/main/charts/argo-cd#upgrading , so I think we need to add this section on argo-workflow's README as well.

WDYT @stefansedich @paguos @vladlosev @yann-soubeyrand @jmeridth ? 🙋

yu-croco avatar Sep 01 '22 03:09 yu-croco

This was completed with #1472

jmeridth avatar Oct 24 '22 16:10 jmeridth