argo-helm icon indicating copy to clipboard operation
argo-helm copied to clipboard

Can we copy the LICENSE file into each of the helm charts?

Open eyal-lantzman opened this issue 1 year ago • 2 comments

Is your feature request related to a problem?

Enterprise helm-chart procurement tools fails to identify the license for each of the helm charts

Related helm chart

argo-cd, argo-events, argo-rollouts, argo-workflows, argocd-image-updater

Describe the solution you'd like

Copy the file into each of the charts.

Describe alternatives you've considered

manual procurement which is very slow and creates a lot of friction point

Additional context

No response

eyal-lantzman avatar Jul 08 '22 13:07 eyal-lantzman

I don't think that this makes sense for us. We want to follow the DRY principle. Are there other options for you? Maybe a chart annotation (https://artifacthub.io/docs/topics/annotations/helm/)?

mkilchhofer avatar Jul 09 '22 22:07 mkilchhofer

The ideal outcome I’m looking for is that there’s a license file per chart.

A chart is an independent deployable unit, and the convention is to have LICENSE file at that unit level.

If the annotation will do just that, great. Otherwise, if there’s a way to copy the file during build/publishing to artifacthub, that should work as well.

Third option, to avoid DRY, is to possible symlink the file to the LICENSE file at root. https://stackoverflow.com/questions/954560/how-does-git-handle-symbolic-links

Thanks

On 9 Jul 2022, at 23:40, Marco Kilchhofer @.***> wrote:



I don't think that this makes sense for us. We want to follow the DRY principle. Are there other options for you? Maybe a chart annotation (https://artifacthub.io/docs/topics/annotations/helm/)?

— Reply to this email directly, view it on GitHubhttps://github.com/argoproj/argo-helm/issues/1364#issuecomment-1179616625, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AD6OT5HUTUS5TA5FHAJJ66TVTH5WBANCNFSM53A6FZ2Q. You are receiving this because you authored the thread.Message ID: @.***>

eyal-lantzman avatar Jul 10 '22 07:07 eyal-lantzman

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Sep 09 '22 03:09 github-actions[bot]