argo-helm icon indicating copy to clipboard operation
argo-helm copied to clipboard

feat(argocd-apps): adopt additional Applications/Projects from argo-cd chart

Open yu-croco opened this issue 2 years ago • 1 comments

In order to decide how to manage argo-cd/crds, I adopted values from argo-cd. *After merging this PR, I will merge https://github.com/argoproj/argo-helm/pull/1357.

  • other reference: https://github.com/argoproj/argo-helm/pull/1342#pullrequestreview-1019481838

Signed-off-by: yu-croco [email protected]

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • [x] I have bumped the chart version according to versioning
  • [x] I have updated the documentation according to documentation
  • [x] I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • [x] Any new values are backwards compatible and/or have sensible default.
  • [x] I have signed off all my commits as required by DCO.
  • [ ] My build is green (troubleshooting builds).

Changes are automatically published when merged to main. They are not published on branches.

yu-croco avatar Jul 02 '22 06:07 yu-croco

~~It looks Lint PR / Validate PR title (pull_request_target) CI refers config on master, so the title of argocd-apps is treated as invalid. 😇 It will work well from next PR, I think.~~ ~~CI: https://github.com/argoproj/argo-helm/runs/7160137094?check_suite_focus=true~~

[updated] Resolved by merging https://github.com/argoproj/argo-helm/pull/1414 .

yu-croco avatar Jul 02 '22 06:07 yu-croco

Hi @oliverbaehler , could you please review and approve this PR to merge, though it's related to argo-cd? 🙋 🙇

yu-croco avatar Aug 22 '22 00:08 yu-croco