fix(argo-cd): argo-cd notifications config map & secret names

[Voziv]

The notifications controller is hard coded to look for argocd-notifications-secret and argocd-notifications-cm. Unless this changes I think the sane default should be argocd-notifications-cm & argocd-notifications-secret

fixes: #1187

Checklist:

• [x] I have bumped the chart version according to versioning
• [x] I have updated the documentation according to documentation
• [x] I have updated the chart changelog with all the changes that come with this pull request according to changelog.
• [x] Any new values are backwards compatible and/or have sensible default.
• [x] I have signed off all my commits as required by DCO.
• [ ] My build is green (troubleshooting builds).

Changes are automatically published when merged to main. They are not published on branches.

[Voziv]

We only speak about the bot container right?

All other things should be setup correctly. The name is injected as CLI argument already:

Ah I see. I think the bug may be in the argo-cd notifications code then if it's supposed to be taking the names of the configmap/secret as arguments.

I'm not super well versed in go yet, but I believe it's this line that causes the errors: https://github.com/argoproj/argo-cd/blob/4f155b539b925c2ad732a57fd03a5b5fb8605ae2/cmd/argocd/commands/admin/notifications.go#L33

settings.GetFactorySettings(argocdService, "argocd-notifications-secret", "argocd-notifications-cm"), func(clientConfig clientcmd.ClientConfig) {

That said I've noticed that we're still on argocd 2.3.3, I'll try updating our chart version tomorrow morning to see if it's still happening.

[Voziv]

Updating to the latest chart I still get the same error

time="2022-06-02T13:41:33Z" level=error msg="Failed to process: secret \"argocd-notifications-secret\" not found" resource=argocd/linkerd

Note: linkerd is just the name of an app, every single app name is listed with this error in the argocd-notifications-controller-bot pod

However I do agree with what @mkilchhofer is getting at. This is likely a bug in argo-cd so I'll file a report there.

In the meantime a fix I can apply myself is overriding the config and secret names using notifications.cm.name and notifications.secret.name values.

Edit: I also tested the latest chart + argocd v2.4.0-rc4 and the problem still occurs. Issue with argoproj/argo-cd is now open

[mkilchhofer]

I also started a discussion in slack over there: https://cloud-native.slack.com/archives/C020XM04CUW/p1654109494458449

[mkilchhofer]

Update in Slack:

xref: https://github.com/argoproj/argo-cd/issues/9869

[Voziv]

I'm realizing there's some missing context that I could have repeated in this PR. In my reply on #1187 I identified that in the argocd repository there is a hard coded secret name which is what I believe causes the errors.

I'll post this in slack as well

[mkilchhofer]

xref: #1340 as it also fixed things regarding this context here - except for the bot

[pdrastil]

Resolved via https://github.com/argoproj/argo-helm/pull/1419