argo-events icon indicating copy to clipboard operation
argo-events copied to clipboard

Sensors are coupled to EventSourceNames

Open paveq opened this issue 4 years ago • 7 comments

Currently sensors are required to specify eventSourceName, in addition to events they are interested.

Expected behavior It is enough to specify only event name.

As example: there is event named "alert", and alerts can come from various systems, and sensor processes these (eg. workflow that sends email). Each time new alert generating system is added, sensor needs to be modified.

paveq avatar Jan 13 '21 22:01 paveq

This is an interesting suggestion, allowing one of eventSourceName and eventName optional. Thoughts? @VaibhavPage

whynowy avatar Jan 13 '21 23:01 whynowy

Could add, that currently it is possible to create a sensor without eventSourceName, but it won't receive any events. This can be bit confusing.

paveq avatar Jan 14 '21 07:01 paveq

Could add, that currently it is possible to create a sensor without eventSourceName, but it won't receive any events. This can be bit confusing.

Now it expects both present, somehow there's not a validation in place.

whynowy avatar Jan 14 '21 08:01 whynowy

+1

vfarcic avatar Feb 09 '21 11:02 vfarcic

+1

natalie-elizabeth avatar Mar 08 '21 11:03 natalie-elizabeth

@whynowy how is the topic name constructed for eventbus?

VaibhavPage avatar Mar 08 '21 16:03 VaibhavPage

+1

zoftdev avatar Jun 22 '21 08:06 zoftdev