argo-cd icon indicating copy to clipboard operation
argo-cd copied to clipboard

feat: support Knative Serving 1.5 Custom Health Checks

Open wei840222 opened this issue 2 years ago • 1 comments

update https://argo-cd.readthedocs.io/en/stable/operator-manual/health/#way-2-contribute-a-custom-health-check for Knative Serving CR in v1.5

wei840222 avatar Jun 20 '22 04:06 wei840222

Codecov Report

Base: 46.85% // Head: 46.85% // No change to project coverage :thumbsup:

Coverage data is based on head (c6ba18f) compared to base (8e57f53). Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9719   +/-   ##
=======================================
  Coverage   46.85%   46.85%           
=======================================
  Files         240      240           
  Lines       39948    39948           
=======================================
  Hits        18719    18719           
  Misses      19336    19336           
  Partials     1893     1893           
Impacted Files Coverage Δ
util/settings/settings.go 48.87% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jun 20 '22 04:06 codecov[bot]

@wei840222 is it necessary to delete the old checks? Seems like it would be nice to continue to support those.

crenshaw-dev avatar Oct 21 '22 16:10 crenshaw-dev

@crenshaw-dev hi, I revert the deleted files.

wei840222 avatar Nov 03 '22 15:11 wei840222