argo-cd icon indicating copy to clipboard operation
argo-cd copied to clipboard

docs: updated okta oidc config

Open huynhj93 opened this issue 2 years ago • 2 comments

Summary

The OKTA OIDC docs are missing details on how to set up the OKTA application. I've added that and pictures to reference on how to do so. I've also added in detail how to edit the config maps and secrets for the client secret for the application.

Checklist:

  • [ c] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • [ n/a] The title of the PR states what changed and the related issues number (used for the release note).
  • [n/a ] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • [ n/a] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • [ no] Does this PR require documentation updates?
  • [ yes] I've updated documentation as required by this PR.
  • [ no] Optional. My organization is added to USERS.md.
  • [ yes] I have signed off all my commits as required by DCO
  • [ n/a] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • [ n/a] My build is green (troubleshooting builds).

huynhj93 avatar Jun 06 '22 17:06 huynhj93

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7ca8c11) 45.79% compared to head (7cd6c89) 45.65%. Report is 1990 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9588      +/-   ##
==========================================
- Coverage   45.79%   45.65%   -0.15%     
==========================================
  Files         222      237      +15     
  Lines       26377    28728    +2351     
==========================================
+ Hits        12079    13115    +1036     
- Misses      12650    13809    +1159     
- Partials     1648     1804     +156     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 06 '22 17:06 codecov[bot]

In terms of feedback, I was able to follow this and get everything working. Thanks for figuring this out!

jdmaguire avatar Aug 16 '22 19:08 jdmaguire