argo-cd
argo-cd copied to clipboard
feat: add projects filter to app sync command (#8320)
Signed-off-by: Chetan Banavikalmutt [email protected]
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
- [x] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
- [x] The title of the PR states what changed and the related issues number (used for the release note).
- [x] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
- [x] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
- [x] Does this PR require documentation updates?
- [x] I've updated documentation as required by this PR.
- [x] Optional. My organization is added to USERS.md.
- [x] I have signed off all my commits as required by DCO
- [ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
- [ ] My build is green (troubleshooting builds).
Using the project filter we can sync apps that belong to a particular project
argocd app sync --project test --project dev
The above command would sync all apps in the projects test and dev
Closes: #8320
Codecov Report
Merging #8343 (8f2db31) into master (0ff1ada) will decrease coverage by
0.05%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## master #8343 +/- ##
==========================================
- Coverage 44.96% 44.91% -0.06%
==========================================
Files 212 212
Lines 25261 25271 +10
==========================================
- Hits 11359 11350 -9
- Misses 12295 12317 +22
+ Partials 1607 1604 -3
Impacted Files | Coverage Δ | |
---|---|---|
cmd/argocd/commands/app.go | 9.12% <0.00%> (-0.05%) |
:arrow_down: |
applicationset/services/scm_provider/github.go | 63.52% <0.00%> (-17.65%) |
:arrow_down: |
server/server.go | 55.57% <0.00%> (+0.16%) |
:arrow_up: |
applicationset/services/scm_provider/utils.go | 88.50% <0.00%> (+4.59%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 0ff1ada...8f2db31. Read the comment docs.
@chetan-rns sorry, I let this one slip through the cracks. Can you resolve conflicts, and I'll review again?
hey there - I originally reported the issue and noticed this PR is still open. Happy to jump in and help get it across the finish line!
@justinwatkinson would you be willing to open a new PR based on this one and resolve the conflicts? I'd review.
Certainly, that sounds reasonable.
I've addressed the merge conflict and moved the latest to this PR:
https://github.com/argoproj/argo-cd/pull/10133
I'll add any additional context there.
Superseded by https://github.com/argoproj/argo-cd/pull/10133, which is now merged.