argo-cd icon indicating copy to clipboard operation
argo-cd copied to clipboard

feat(appset): add DefaultPrune support to RollingSync (#25444)

Open fsdkibe opened this issue 3 weeks ago • 2 comments

Fixes #25444

Checklist:

  • [x] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • [x] The title of the PR states what changed and the related issues number (used for the release note).
  • [x] The title of the PR conforms to the Title of the PR
  • [x] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • [ ] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • [x] Does this PR require documentation updates?
  • [ ] I've updated documentation as required by this PR.
  • [x] I have signed off all my commits as required by DCO
  • [x] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • [x] My build is green (troubleshooting builds).
  • [x] My new feature complies with the feature status guidelines.
  • [x] I have added a brief description of why this PR is necessary and/or what this PR solves.
  • [ ] Optional. My organization is added to USERS.md.
  • [ ] Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

fsdkibe avatar Dec 03 '25 19:12 fsdkibe

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • :rocket: /bns:deploy to redeploy the environment
  • :x: /bns:delete to remove the environment

bunnyshell[bot] avatar Dec 03 '25 19:12 bunnyshell[bot]

Codecov Report

:x: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 62.48%. Comparing base (7cdc0f9) to head (827365c). :warning: Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
...cationset/controllers/applicationset_controller.go 80.00% 2 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #25501      +/-   ##
==========================================
+ Coverage   62.45%   62.48%   +0.02%     
==========================================
  Files         351      351              
  Lines       49490    49500      +10     
==========================================
+ Hits        30910    30928      +18     
+ Misses      15621    15611      -10     
- Partials     2959     2961       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 03 '25 20:12 codecov[bot]

@nitishfy, this is ready for review. Please let me know if any changes are required.

fsdkibe avatar Dec 04 '25 13:12 fsdkibe