chore(deps): Bump kustomize to v5.8.0

[marcingy]

Checklist:

• [ ] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• [ ] The title of the PR states what changed and the related issues number (used for the release note).
• [ ] The title of the PR conforms to the Title of the PR
• [ ] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• [ ] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• [ ] Does this PR require documentation updates?
• [ ] I've updated documentation as required by this PR.
• [ ] I have signed off all my commits as required by DCO
• [ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• [ ] My build is green (troubleshooting builds).
• [ ] My new feature complies with the feature status guidelines.
• [ ] I have added a brief description of why this PR is necessary and/or what this PR solves.
• [ ] Optional. My organization is added to USERS.md.
• [ ] Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

[bunnyshell[bot]]

:x: Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

• :rocket: /bns:deploy to deploy the environment

[codecov[bot]]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 62.38%. Comparing base (5db7846) to head (b04f5df). :warning: Report is 26 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #25437      +/-   ##
==========================================
+ Coverage   62.29%   62.38%   +0.08%     
==========================================
  Files         351      351              
  Lines       49391    49401      +10     
==========================================
+ Hits        30770    30817      +47     
+ Misses      15679    15635      -44     
- Partials     2942     2949       +7     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[reggie-k]

@marcingy this merged PR https://github.com/argoproj/argo-cd/pull/25362 is bumping Kustomize to 5.7.1, so part of the requested changes are already in. You will have to update the branch and resolve some small conflicts though.

[Skaronator]

I implemented that fix in Kustomize, and I’m really looking forward to it landing in ArgoCD. (that’s why I created it in the first place)

The only situation where this might break existing setups is when Kustomize is used with Helm charts that don’t define namespace: {{ .Release.Namespace }}. (This is a limitation from helm since it handles helm install -n xy differently than helm template -n xy - although I'm not sure if that is fixed with Helm 4)

Previously, Kustomize would simply search, replace, or set all namespaces after rendering the Helm chart. This made it impossible to deploy Helm charts that span multiple namespaces. For example, the cert-manager chart, which uses kube-system for leases.

[crenshaw-dev]

@marcingy can you add upgrade notes explaining the change in behavior?

[reggie-k]

I added a small suggestion for correction in the doc, other than that LGTM!