argo-cd icon indicating copy to clipboard operation
argo-cd copied to clipboard

fix(hydrator): Argo CD automatically handle webhooks when the webhook body matches the syncSource

Open pbhatnagar-oss opened this issue 1 month ago • 2 comments

Fixes https://github.com/argoproj/argo-cd/issues/25094

Checklist:

  • [ ] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • [x] The title of the PR states what changed and the related issues number (used for the release note).
  • [ ] The title of the PR conforms to the Title of the PR
  • [x] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • [ ] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • [ ] Does this PR require documentation updates?
  • [ ] I've updated documentation as required by this PR.
  • [x] I have signed off all my commits as required by DCO
  • [ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • [ ] My build is green (troubleshooting builds).
  • [ ] My new feature complies with the feature status guidelines.
  • [ ] I have added a brief description of why this PR is necessary and/or what this PR solves.
  • [ ] Optional. My organization is added to USERS.md.
  • [ ] Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

pbhatnagar-oss avatar Nov 14 '25 21:11 pbhatnagar-oss

:x: Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • :rocket: /bns:deploy to deploy the environment

bunnyshell[bot] avatar Nov 14 '25 21:11 bunnyshell[bot]

Codecov Report

:x: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 62.29%. Comparing base (5c6aa59) to head (cc07115). :warning: Report is 69 commits behind head on master.

Files with missing lines Patch % Lines
util/webhook/webhook.go 66.66% 2 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #25295      +/-   ##
==========================================
+ Coverage   62.23%   62.29%   +0.05%     
==========================================
  Files         351      351              
  Lines       49346    49354       +8     
==========================================
+ Hits        30712    30743      +31     
+ Misses      15696    15679      -17     
+ Partials     2938     2932       -6     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 02 '25 22:12 codecov[bot]

Closing in favour of https://github.com/argoproj/argo-cd/pull/25516

agaudreault avatar Dec 17 '25 18:12 agaudreault