GitHub App Auth repositories incorrectly updatable in the GUI

[allanyung]

Checklist:

• [x] I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
• [x] I've included steps to reproduce the bug.
• [x] I've pasted the output of argocd version.

Describe the bug

HTTP/HTTPS git repositories in the GUI may be updated. Git repositories using GitHub App Auth are not supposed to be updatable, but a bug in the GUI permits this.

Worse still, should you save a change, the githubAppID and githubAppInstallationID get set to 0 and the githubAppPrivateKey becomes an empty string.

To Reproduce

A repository with GitHub App Auth needs to exist first, then in the GUI:

Settings -> Repositories -> click on the repository -> edit panel slides in

Expected behavior

The repository is not clickable, and therefore does not present the edit panel

Screenshots

This edit panel should not appear when clicking GitHub App Auth repositories

Version

This happens on the current master branch, the most recent release is v3.2.0

[afzal442]

@allanyung this happens on v3.1.x as well. I was able to repro.