argo-cd icon indicating copy to clipboard operation
argo-cd copied to clipboard

test: health check test

Open solomon-kibret opened this issue 8 months ago • 3 comments

Checklist:

  • [ ] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • [ ] The title of the PR states what changed and the related issues number (used for the release note).
  • [ ] The title of the PR conforms to the Toolchain Guide
  • [ ] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • [ ] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • [ ] Does this PR require documentation updates?
  • [ ] I've updated documentation as required by this PR.
  • [ ] I have signed off all my commits as required by DCO
  • [ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • [ ] My build is green (troubleshooting builds).
  • [ ] My new feature complies with the feature status guidelines.
  • [ ] I have added a brief description of why this PR is necessary and/or what this PR solves.
  • [ ] Optional. My organization is added to USERS.md.
  • [ ] Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

solomon-kibret avatar Jun 02 '25 15:06 solomon-kibret

:x: Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • :rocket: /bns:deploy to deploy the environment

bunnyshell[bot] avatar Jun 02 '25 15:06 bunnyshell[bot]

@solomon-kibret can you provide details about the problem being fixed?

crenshaw-dev avatar Jun 02 '25 16:06 crenshaw-dev

@solomon-kibret can you provide details about the problem being fixed?

I am figuring things out as I go but I added checks if the currentStatus is orphaned or NotReconciled then the hs.status would be Degraded. The "Unknown" status is probably redundant.

solomon-kibret avatar Jun 02 '25 20:06 solomon-kibret