argo-cd
argo-cd copied to clipboard
feat: Add custom healthcheck for NATS resources #23167
NATS uses a controller called nacks to deploy resources in a deployed server based on CRDs created. The controller provides kubernetes events giving the status updates of the processing of the CRDs. Closes https://github.com/argoproj/argo-cd/issues/23167
Checklist:
- [x] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
- [x] The title of the PR states what changed and the related issues number (used for the release note).
- [x] The title of the PR conforms to the Toolchain Guide
- [x] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
- [ ] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
- [ ] Does this PR require documentation updates?
- [ ] I've updated documentation as required by this PR.
- [x] I have signed off all my commits as required by DCO
- [x] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
- [ ] My build is green (troubleshooting builds).
- [ ] My new feature complies with the feature status guidelines.
- [x] I have added a brief description of why this PR is necessary and/or what this PR solves.
- [ ] Optional. My organization is added to USERS.md.
- [ ] Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).
:x: Preview Environment undeployed from Bunnyshell
Available commands (reply to this comment):
- :rocket:
/bns:deployto deploy the environment
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Please upload report for BASE (
master@97a38b4). Learn more about missing BASE report. Report is 102 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #23180 +/- ##
=========================================
Coverage ? 59.98%
=========================================
Files ? 343
Lines ? 57890
Branches ? 0
=========================================
Hits ? 34725
Misses ? 20384
Partials ? 2781
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.