argo-cd icon indicating copy to clipboard operation
argo-cd copied to clipboard

fix: Fixed inconsistent alignment of titles and headings in status panel

Open sivasath16 opened this issue 8 months ago • 4 comments

Fixes #23022

Checklist:

  • [x] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • [x] The title of the PR states what changed and the related issues number (used for the release note).
  • [x] The title of the PR conforms to the Toolchain Guide
  • [x] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • [x] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • [ ] Does this PR require documentation updates?
  • [ ] I've updated documentation as required by this PR.
  • [x] I have signed off all my commits as required by DCO
  • [ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • [ ] My build is green (troubleshooting builds).
  • [ ] My new feature complies with the feature status guidelines.
  • [ ] I have added a brief description of why this PR is necessary and/or what this PR solves.
  • [ ] Optional. My organization is added to USERS.md.
  • [ ] Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

sivasath16 avatar May 26 '25 23:05 sivasath16

:x: Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • :rocket: /bns:deploy to deploy the environment

bunnyshell[bot] avatar May 26 '25 23:05 bunnyshell[bot]

@reggie-k, I've fixed the UI bug. Can you take a look at it?

sivasath16 avatar May 27 '25 00:05 sivasath16

It would be better if you could please provide a before and after of the UI changes.

surajyadav1108 avatar May 27 '25 06:05 surajyadav1108

The easiest way to test the worst of the alignment issues (the conditions panel) is to intentionally add a typo to the source.repoURL field. I tested with that situation, looks like this PR doesn't yet address that alignment issue. image

crenshaw-dev avatar May 27 '25 14:05 crenshaw-dev

image image

These are the current improvements done based on previous review. Please review.

sivasath16 avatar Jul 07 '25 22:07 sivasath16

:x: Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • :rocket: /bns:deploy to deploy the environment

bunnyshell[bot] avatar Jul 08 '25 20:07 bunnyshell[bot]

Hey @nitishfy, I've made sure that all the necessary checks are passed. Please verify and merge the changes. Thanks.

sivasath16 avatar Jul 08 '25 20:07 sivasath16

Hey @nitishfy @linghaoSu , could you please review and merge the code. Thanks

sivasath16 avatar Jul 11 '25 15:07 sivasath16

Hi @nitishfy, could you please verify and merge the changes? Thank you.

sivasath16 avatar Sep 17 '25 03:09 sivasath16