argo-cd icon indicating copy to clipboard operation
argo-cd copied to clipboard

feat(health-check): Add resource_customizations for karpenter

Open kingbj940429 opened this issue 7 months ago • 4 comments

Related to https://github.com/argoproj/argo-cd/issues/22885

Add health checks for karpenter.sh v1: NodePool and EC2NodeClass

Checklist:

  • [x] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • [x] The title of the PR states what changed and the related issues number (used for the release note).
  • [x] The title of the PR conforms to the Toolchain Guide
  • [ ] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • [ ] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • [ ] Does this PR require documentation updates?
  • [ ] I've updated documentation as required by this PR.
  • [x] I have signed off all my commits as required by DCO
  • [ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • [ ] My build is green (troubleshooting builds).
  • [ ] My new feature complies with the feature status guidelines.
  • [x] I have added a brief description of why this PR is necessary and/or what this PR solves.
  • [ ] Optional. My organization is added to USERS.md.
  • [ ] Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

kingbj940429 avatar May 25 '25 09:05 kingbj940429

:x: Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • :rocket: /bns:deploy to deploy the environment

bunnyshell[bot] avatar May 25 '25 09:05 bunnyshell[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :warning: Please upload report for BASE (master@eb794b7). Learn more about missing BASE report. :warning: Report is 411 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #23139   +/-   ##
=========================================
  Coverage          ?   59.94%           
=========================================
  Files             ?      341           
  Lines             ?    57818           
  Branches          ?        0           
=========================================
  Hits              ?    34660           
  Misses            ?    20370           
  Partials          ?     2788           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 25 '25 17:05 codecov[bot]

@agaudreault Hi Could you please review this PR?

kingbj940429 avatar May 26 '25 00:05 kingbj940429

The code looks good to me!

olivergondza avatar May 28 '25 06:05 olivergondza