argo-cd icon indicating copy to clipboard operation
argo-cd copied to clipboard

feat: support destinationServiceAccounts in global projects

Open enneitex opened this issue 7 months ago • 3 comments

fixes https://github.com/argoproj/argo-cd/issues/22150

Implementation is inspired by other fields which are already being inherited from global projects. I also fixed the columns width

Checklist:

  • [ ] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • [ ] The title of the PR states what changed and the related issues number (used for the release note).
  • [ ] The title of the PR conforms to the Toolchain Guide
  • [ ] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • [ ] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • [ ] Does this PR require documentation updates?
  • [ ] I've updated documentation as required by this PR.
  • [ ] I have signed off all my commits as required by DCO
  • [ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • [ ] My build is green (troubleshooting builds).
  • [ ] My new feature complies with the feature status guidelines.
  • [ ] I have added a brief description of why this PR is necessary and/or what this PR solves.
  • [ ] Optional. My organization is added to USERS.md.
  • [ ] Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

enneitex avatar May 20 '25 12:05 enneitex

:x: Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • :rocket: /bns:deploy to deploy the environment

bunnyshell[bot] avatar May 20 '25 12:05 bunnyshell[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 60.20%. Comparing base (ef8d03c) to head (379ba39). :warning: Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #23059      +/-   ##
==========================================
+ Coverage   60.18%   60.20%   +0.02%     
==========================================
  Files         348      348              
  Lines       59889    59907      +18     
==========================================
+ Hits        36045    36069      +24     
+ Misses      20961    20960       -1     
+ Partials     2883     2878       -5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 20 '25 14:05 codecov[bot]

Hello @nitishfy As I said on slack, there is no breaking change, This PR only extends Global Projects to work with the field destinationServiceAccounts

The change mentionned in the doc is related to the feature application.sync.impersonation.enabled. Maybe another PR can be opened to enhance doc about impersonation.

enneitex avatar May 22 '25 14:05 enneitex

:x: Preview Environment undeployed from Bunnyshell

Available commands (reply to this comment):

  • :rocket: /bns:deploy to deploy the environment

bunnyshell[bot] avatar Aug 26 '25 19:08 bunnyshell[bot]