argo-cd icon indicating copy to clipboard operation
argo-cd copied to clipboard

chore: replace heptio-images with argocd-e2e-container (cherry-pick #23040)

Open nitishfy opened this issue 7 months ago • 3 comments

Cherry-pick #23040

Checklist:

  • [ ] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • [ ] The title of the PR states what changed and the related issues number (used for the release note).
  • [ ] The title of the PR conforms to the Toolchain Guide
  • [ ] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • [ ] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • [ ] Does this PR require documentation updates?
  • [ ] I've updated documentation as required by this PR.
  • [ ] I have signed off all my commits as required by DCO
  • [ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • [ ] My build is green (troubleshooting builds).
  • [ ] My new feature complies with the feature status guidelines.
  • [ ] I have added a brief description of why this PR is necessary and/or what this PR solves.
  • [ ] Optional. My organization is added to USERS.md.
  • [ ] Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

nitishfy avatar May 20 '25 10:05 nitishfy

Thanks @nitishfy! Any reason for using different container argoprojlabs/argocd-e2e-container tags? (0.2, 0.1 and unpinned)

reggie-k avatar May 20 '25 10:05 reggie-k

Thanks @nitishfy! Any reason for using different container argoprojlabs/argocd-e2e-container tags? (0.2, 0.1 and unpinned)

Can you refer the line that you're refering to?

nitishfy avatar May 20 '25 12:05 nitishfy

Codecov Report

:x: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 55.83%. Comparing base (c27a9d3) to head (773878e). :warning: Report is 49 commits behind head on release-3.0.

Files with missing lines Patch % Lines
cmd/argocd/commands/admin/app.go 0.00% 1 Missing :warning:
cmd/argocd/commands/app.go 0.00% 1 Missing :warning:
Additional details and impacted files
@@               Coverage Diff               @@
##           release-3.0   #23058      +/-   ##
===============================================
- Coverage        55.93%   55.83%   -0.11%     
===============================================
  Files              343      343              
  Lines            57387    57387              
===============================================
- Hits             32102    32040      -62     
- Misses           22643    22685      +42     
- Partials          2642     2662      +20     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 27 '25 13:05 codecov[bot]