feat: adding arrow key support to app dropdown
*this code was generated using Cursor.
make the applications details app dropdown navigatable by using the arrowkeys. the enter key opens the app page for the selected application, similar to how a click would work.
leaving this PR as a draft so that I can review it myself, and ensure code has been reused wherever available.
#22031
https://github.com/user-attachments/assets/15bc31da-cf8b-408c-9ac7-a6dde25c8955
Checklist:
- [ ] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
- [ ] The title of the PR states what changed and the related issues number (used for the release note).
- [ ] The title of the PR conforms to the Toolchain Guide
- [ ] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
- [ ] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
- [ ] Does this PR require documentation updates?
- [ ] I've updated documentation as required by this PR.
- [ ] I have signed off all my commits as required by DCO
- [ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
- [ ] My build is green (troubleshooting builds).
- [ ] My new feature complies with the feature status guidelines.
- [ ] I have added a brief description of why this PR is necessary and/or what this PR solves.
- [ ] Optional. My organization is added to USERS.md.
- [ ] Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).
:exclamation: Preview Environment undeploy from Bunnyshell failed
See: Environment Details | Pipeline Logs
Available commands (reply to this comment):
- :rocket:
/bns:deployto redeploy the environment - :x:
/bns:deleteto try again to remove the environment
I tried re-using the Autocomplete component, which is also used in the Search bar, and found that using a searchbar as a dropdown selector in this view made for an awkward experiencing. I do think this PR has some unnecessary code, and would like to know the "right" way to do this if the reviewer has time.
https://github.com/argoproj/argo-cd/blob/master/ui/src/app/applications/components/applications-list/applications-list.tsx#L191
🔴 Preview Environment stopped on Bunnyshell
See: Environment Details | Pipeline Logs
Available commands (reply to this comment):
- 🔵
/bns:startto start the environment- 🚀
/bns:deployto redeploy the environment- ❌
/bns:deleteto remove the environment
/bns:start