argo-cd
argo-cd copied to clipboard
fix(rbac): Add rights on applicationsets for the application controller
Upstream fix for: https://github.com/argoproj/argo-helm/issues/2974
Checklist:
- [x] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
- [x] The title of the PR states what changed and the related issues number (used for the release note).
- [x] The title of the PR conforms to the Toolchain Guide
- [x] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
- [x] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
- [x] Does this PR require documentation updates?
- [x] I've updated documentation as required by this PR.
- [x] I have signed off all my commits as required by DCO
- [x] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
- [x] My build is green (troubleshooting builds).
- [x] My new feature complies with the feature status guidelines.
- [x] I have added a brief description of why this PR is necessary and/or what this PR solves.
- [x] Optional. My organization is added to USERS.md.
- [x] Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).
:x: Preview Environment deleted from Bunnyshell
Available commands (reply to this comment):
- :rocket:
/bns:deployto deploy the environment
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 55.60%. Comparing base (
fa747f9) to head (a4efab1). Report is 371 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #20352 +/- ##
==========================================
- Coverage 55.67% 55.60% -0.08%
==========================================
Files 339 339
Lines 56814 56814
==========================================
- Hits 31634 31590 -44
- Misses 22535 22570 +35
- Partials 2645 2654 +9
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Updated to clarify the namespaced mode intent in the documentation
@crenshaw-dev are you ok with the content now ?