argo-cd icon indicating copy to clipboard operation
argo-cd copied to clipboard

Add support for route object in Openshift

Open tomerle03 opened this issue 1 year ago • 2 comments

Summary

In openshift when you deploy a route without a host, the Openshift will generate a host for the route

But currently when you deploy a route object in argocd without .spec.host argocd will mark it as OutOfSync because in the live manifest the .spec.host is auto generated by the cluster. Right now the only way to solve this issue is to implement the ignoreDifferences:

ignoreDiffreneces:
  - group: route.openshift.io
    kind: Route
    jsonPointers:
      - /spec/host

Proposal

I think that part of the route health check should include a check that the .spec.host in the live manifest is not empty

tomerle03 avatar Oct 09 '24 08:10 tomerle03

You can update the resource health check here which will show the status of the resource.

rumstead avatar Oct 10 '24 17:10 rumstead

I'm not able to reproduce the issue with this CRD: https://github.com/openshift/router/blob/72114ea78be0a032d5cdddcad694e0a352a00e93/deploy/route_crd.yaml

https://github.com/user-attachments/assets/7e20fe44-58cf-496c-81b1-ad724620be75

crenshaw-dev avatar Oct 10 '24 20:10 crenshaw-dev

I also tried reproducing the same in an open-shift cluster, but I don't see the issue.

Desired Manifest: image

LIVE MANIFEST image

Mangaal avatar Oct 18 '24 07:10 Mangaal

What are the versions of ArgoCD and manifests used? @tomerle03, try upgrading ArgoCD and manifest to 2.12 or 2.13 and see if the issue still persists.

andrii-korotkov-verkada avatar Nov 10 '24 22:11 andrii-korotkov-verkada