chore(repo-server): add gc.autopacklimit setting
Closes https://github.com/argoproj/argo-cd/issues/20263
Allow configure repo-server to specifies the limit for automatic git repacking.
Checklist:
- [X] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
- [X] The title of the PR states what changed and the related issues number (used for the release note).
- [X] The title of the PR conforms to the Toolchain Guide
- [X] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
- [ ] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
- [x] Does this PR require documentation updates?
- [x] I've updated documentation as required by this PR.
- [X] I have signed off all my commits as required by DCO
- [] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
- [] My build is green (troubleshooting builds).
- [x] My new feature complies with the feature status guidelines.
- [X] I have added a brief description of why this PR is necessary and/or what this PR solves.
- [ ] Optional. My organization is added to USERS.md.
- [ ] Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).
:x: Preview Environment deleted from Bunnyshell
Available commands (reply to this comment):
- :rocket:
/bns:deployto deploy the environment
:x: Preview Environment deleted from Bunnyshell
Available commands (reply to this comment):
- :rocket:
/bns:deployto deploy the environment
Codecov Report
Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.
Project coverage is 55.31%. Comparing base (
5ef4faa) to head (4b79bb5). Report is 382 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| util/git/client.go | 75.00% | 2 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #20266 +/- ##
==========================================
- Coverage 55.39% 55.31% -0.09%
==========================================
Files 339 339
Lines 57176 57190 +14
==========================================
- Hits 31672 31633 -39
- Misses 22797 22835 +38
- Partials 2707 2722 +15
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I think we need a minimal way to reproduce the issue so we can test before/after and prove to ourselves that this solves the problem. I know you've tested in your env, but I think for due diligence we should test in a second env.
Make a lot of sense, let me prepare an environment to reproduce it and attach it to the description of this MR (and issue)
Thanks!
Code changes already done! If you want to take a look Im gonna work to make the issue reproducible :)
After a few weeks, it seems helps but not completely solve the problem (the suddenly decrease is effect of running kubectl delete of failed pods)
Make sense to add the chore? Wdyt?
Finally, the root of the problem was insufficient CPU.
With insufficient CPU, git operations start failing with timeouts etc,. as described here https://github.com/argoproj/argo-cd/issues/18831
I think this MR doesn't solve the problem but open the door about how to add new git client configurations in ArgoCD.
Then, make sense to keep it or doesn't make sense and it is better to close it?