argo-cd
argo-cd copied to clipboard
argoproj
fix(hydrator): consider repo+branch+path a unique destination if they are the same
I tried to resolve this issue (#19068) since the PR hasn't been opened for a while. If someone is already working on it, please let me know. I will stop working on this PR.
Changes made in this PR:
- Clean path before checking if the path is the same
- Add a test to verify that an error occurs for duplicate destinations
- Add documentation that the destination must be unique
Checklist:
- [ ] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
- [ ] The title of the PR states what changed and the related issues number (used for the release note).
- [ ] The title of the PR conforms to the Toolchain Guide
- [ ] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
- [ ] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
- [ ] Does this PR require documentation updates?
- [ ] I've updated documentation as required by this PR.
- [ ] I have signed off all my commits as required by DCO
- [ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
- [ ] My build is green (troubleshooting builds).
- [ ] My new feature complies with the feature status guidelines.
- [ ] I have added a brief description of why this PR is necessary and/or what this PR solves.
- [ ] Optional. My organization is added to USERS.md.
- [ ] Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).
Hello @crenshaw-dev. Could you review the PR if you have returned from your vacation please? Thanks!
Hydrator feature is merged, rebase on master and re-open PR if necessary
