argo-cd icon indicating copy to clipboard operation
argo-cd copied to clipboard

Docs - site is confused about current version

Open runofthemill opened this issue 1 year ago • 1 comments

Checklist:

  • [x] I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • [x] I've included steps to reproduce the bug.
  • [ ] I've pasted the output of argocd version.

This may be an RTD bug/change, but the docs are showing this warning in the header: You are viewing the docs for an unreleased version of Argo CD

Screenshot shows the version selected is older, and correctly shows a modal indicating that, but regardless of the selected version, the top banner is present.

Also notable is the window object READTHEDOCS_DATA which is used in the version check is undefined, making me think it may be a change from RTD.

To Reproduce

Visit https://argo-cd.readthedocs.io/en/stable or select any other version

Expected behavior

Only show You are viewing the docs for an unreleased version of Argo CD when viewing https://argo-cd.readthedocs.io/en/latest/.

Screenshots

SCR-20240524-ijsl

Version

N/A

Logs

N/A

runofthemill avatar May 24 '24 16:05 runofthemill

related #18239

surajyadav1108 avatar May 25 '24 05:05 surajyadav1108

I built the docs locally with mkdocs directly to investigate

python3 -m venv /tmp/argocd
source /tmp/argocd/bin/activate
pip install -r docs/requirements.txt

# Install mkdocs if you don't have it, on macOS: brew install mkdocs
mkdocs serve

The version selector was fixed in #18239, but the banner still exists when on stable. It looks like selecting stable does not actually load the stable docs, since the URL is /stable, but the version selector shows latest.

Also, I noticed that the 2.10 and 2.11 releases are completely missing from the version selection.

morremeyer avatar Jun 19 '24 12:06 morremeyer

I think this is fixed, don't see a banner on stable.

andrii-korotkov-verkada avatar Nov 11 '24 06:11 andrii-korotkov-verkada